Skip to content

[Backport 8.x] Fix common query parameters #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2025
Merged

[Backport 8.x] Fix common query parameters #3464

merged 3 commits into from
Jan 13, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 8, 2025

Backport 7aa6d9c from #3297.

@github-actions github-actions bot requested review from a team as code owners January 8, 2025 14:31
@pquentin pquentin closed this Jan 8, 2025
@pquentin pquentin reopened this Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Jan 8, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ccr.delete_auto_follow_pattern ⚪ Missing test Missing test
ccr.follow_info ⚪ Missing test Missing test
ccr.follow_stats ⚪ Missing test Missing test
ccr.follow ⚪ Missing test Missing test
ccr.forget_follower ⚪ Missing test Missing test
ccr.get_auto_follow_pattern ⚪ Missing test Missing test
ccr.pause_auto_follow_pattern ⚪ Missing test Missing test
ccr.pause_follow ⚪ Missing test Missing test
ccr.put_auto_follow_pattern ⚪ Missing test Missing test
ccr.resume_auto_follow_pattern ⚪ Missing test Missing test
ccr.resume_follow ⚪ Missing test Missing test
ccr.stats ⚪ Missing test Missing test
ccr.unfollow ⚪ Missing test Missing test
cluster.allocation_explain 🟢 4/4 4/4
cluster.delete_voting_config_exclusions 🟢 1/1 1/1
cluster.post_voting_config_exclusions 🟢 5/5 5/5
enrich.delete_policy 🟢 9/9 9/9
enrich.execute_policy 🟢 9/9 9/9
enrich.get_policy 🟢 6/6 6/6
enrich.put_policy 🟢 10/10 10/10
enrich.stats 🟢 6/6 6/6
features.get_features 🟢 2/2 2/2
features.reset_features ⚪ Missing test Missing test
ilm.explain_lifecycle 🟢 5/5 5/5
ilm.start ⚪ Missing test Missing test
ilm.stop 🟢 4/4 4/4
indices.field_usage_stats 🟢 5/5 5/5
ingest.get_geoip_database 🟢 6/6 6/6
license.delete 🟢 3/3 3/3
license.post_start_basic 🟢 5/5 5/5
license.post_start_trial 🟢 2/2 2/2
license.post 🟢 1/1 1/1
ml.delete_trained_model 🟢 5/5 5/5
ml.get_memory_stats 🟢 6/6 6/6
nodes.hot_threads 🟢 5/5 5/5
nodes.info 🔴 114/114 1/114
nodes.stats 🔴 51/51 13/51
search_shards 🟢 7/7 7/7
searchable_snapshots.clear_cache 🟢 1/1 1/1
shutdown.get_node ⚪ Missing test Missing test
snapshot.clone 🟢 5/5 5/5
tasks.list 🟢 9/9 9/9
transform.reset_transform 🟢 4/4 4/4
watcher.start 🟢 1/1 1/1
watcher.stop 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta force-pushed the backport-3297-to-8.x branch from be1386a to f6b5495 Compare January 13, 2025 11:40
swallez and others added 3 commits January 13, 2025 12:46
@swallez @pquentin @l-trotta
Fix common query parameters (#3297)
43fccc0 
* Fix many _cat API issues

* Fix "master_timeout" query parameter issues

* Fix "timeout" query parameter issues

* Fix "pretty" & "human" query parameter issues

* Use correct type for the 'time' query parameter

* Address review feedback

* Reduce diff with main branch

* Remove timeout parameter from put_component_template

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 7aa6d9c)
@l-trotta
correct rebase
bb37d04
@l-trotta
this time correct rebase
38b8580
@l-trotta l-trotta force-pushed the backport-3297-to-8.x branch from f6b5495 to 38b8580 Compare January 13, 2025 11:52
@github-actions GitHub Actions
Copy link
Contributor Author

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ccr.delete_auto_follow_pattern ⚪ Missing test Missing test
ccr.follow_info ⚪ Missing test Missing test
ccr.follow_stats ⚪ Missing test Missing test
ccr.follow ⚪ Missing test Missing test
ccr.forget_follower ⚪ Missing test Missing test
ccr.get_auto_follow_pattern ⚪ Missing test Missing test
ccr.pause_auto_follow_pattern ⚪ Missing test Missing test
ccr.pause_follow ⚪ Missing test Missing test
ccr.put_auto_follow_pattern ⚪ Missing test Missing test
ccr.resume_auto_follow_pattern ⚪ Missing test Missing test
ccr.resume_follow ⚪ Missing test Missing test
ccr.stats ⚪ Missing test Missing test
ccr.unfollow ⚪ Missing test Missing test
cluster.allocation_explain 🟢 4/4 4/4
cluster.delete_voting_config_exclusions 🟢 1/1 1/1
cluster.post_voting_config_exclusions 🟢 5/5 5/5
enrich.delete_policy 🟢 9/9 9/9
enrich.execute_policy 🟢 9/9 9/9
enrich.get_policy 🟢 6/6 6/6
enrich.put_policy 🟢 10/10 10/10
enrich.stats 🟢 6/6 6/6
features.get_features 🟢 2/2 2/2
features.reset_features ⚪ Missing test Missing test
ilm.explain_lifecycle 🟢 5/5 5/5
ilm.start ⚪ Missing test Missing test
ilm.stop 🟢 4/4 4/4
indices.field_usage_stats 🟢 5/5 5/5
ingest.get_geoip_database 🟢 6/6 6/6
license.delete 🟢 3/3 3/3
license.post_start_basic 🟢 5/5 5/5
license.post_start_trial 🟢 2/2 2/2
license.post 🟢 1/1 1/1
ml.delete_trained_model 🟢 5/5 5/5
ml.get_memory_stats 🟢 6/6 6/6
nodes.hot_threads 🟢 5/5 5/5
nodes.info 🔴 114/114 1/114
nodes.stats 🔴 51/51 13/51
search_shards 🟢 7/7 7/7
searchable_snapshots.clear_cache 🟢 1/1 1/1
shutdown.get_node ⚪ Missing test Missing test
snapshot.clone 🟢 5/5 5/5
tasks.list 🟢 9/9 9/9
transform.reset_transform 🟢 4/4 4/4
watcher.start 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit d18a342 into 8.x Jan 13, 2025
6 checks passed
@l-trotta l-trotta deleted the backport-3297-to-8.x branch January 13, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pquentin @l-trotta @swallez