Skip to content

Add rescore_vector to knn query, knn section and knn retriever #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

carlosdelest
Copy link
Member

@carlosdelest carlosdelest commented Jan 20, 2025

Adds rescore_vector to knn query, knn search and knn retriever, introduced in elastic/elasticsearch#119835

Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@carlosdelest carlosdelest merged commit 1cb6c16 into main Jan 20, 2025
8 checks passed
@carlosdelest carlosdelest deleted the feature/knn-rescore-vector branch January 20, 2025 17:08
Copy link
Contributor

The backport to 8.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.1 8.1
# Navigate to the new working tree
cd .worktrees/backport-8.1
# Create a new branch
git switch --create backport-3553-to-8.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1cb6c162b8e79497551620088b2a7714e771b59b
# Push it to GitHub
git push --set-upstream origin backport-3553-to-8.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.1

Then, create a pull request where the base branch is 8.1 and the compare/head branch is backport-3553-to-8.1.

@carlosdelest
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

carlosdelest added a commit to carlosdelest/elasticsearch-specification that referenced this pull request Jan 20, 2025
carlosdelest added a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants