Skip to content

Add remove_index_blocks param to _create_from #3566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2025
Merged

Add remove_index_blocks param to _create_from #3566

merged 2 commits into from
Jan 23, 2025

Conversation

parkertimmins
Copy link
Contributor

Add a new parameter to the request body for _create_from/{source}/{dest} api.
Parameter is an optional boolean called remove_index_blocks.

Add to ES in https://github.com/elastic/elasticsearch/pull/120548/files

@parkertimmins parkertimmins mentioned this pull request Jan 22, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
migrate.create_from 🟢 3/3 3/3

You can validate this API yourself by using the make validate target.

pquentin
pquentin reviewed Jan 23, 2025
View reviewed changes
pquentin
pquentin approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pquentin pquentin enabled auto-merge (squash) January 23, 2025 07:36
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
migrate.create_from 🟢 3/3 3/3

You can validate this API yourself by using the make validate target.

@pquentin pquentin merged commit 385bbc3 into main Jan 23, 2025
8 checks passed
@pquentin pquentin deleted the create-from-add-param_remove-index-blocks branch January 23, 2025 07:36
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
@parkertimmins @pquentin @github-actions
Add remove_index_blocks param to _create_from (#3566)
80ff802 
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 385bbc3)
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Merged
pquentin pushed a commit that referenced this pull request Jan 23, 2025
@github-actions @parkertimmins
Add remove_index_blocks param to _create_from (#3566) (#3576)
b1069af 
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 385bbc3)

Co-authored-by: Parker Timmins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
backport 8.19 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parkertimmins @pquentin