Skip to content

Edit migration reindexing summaries #3573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Edit migration reindexing summaries #3573

merged 2 commits into from
Jan 23, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 22, 2025

This PR edits the operation summaries for the new APIs that appear in https://www.elastic.co/docs/api/doc/elasticsearch/group/endpoint-migration

That first line needs to be short and sweet and start with a verb to align with all the other titles that appear in the left-hand navigation. There's some more guidance in https://github.com/elastic/elasticsearch-specification/blob/main/docs/doc-comments-guide.md with more to come soon.

NOTE: I have not drafted descriptions for all the request body and response body properties, but those should eventually be added for clarity and completeness too.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
migrate.cancel_reindex 🟢 2/2 2/2
migrate.create_from 🔴 2/3 3/3
migrate.get_reindex_status 🟢 1/1 1/1
migrate.reindex 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
migrate.cancel_reindex 🟢 2/2 2/2
migrate.create_from 🔴 2/3 3/3
migrate.get_reindex_status 🟢 1/1 1/1
migrate.reindex 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review January 23, 2025 05:26
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.cancel_migrate_reindex 🟢 2/2 2/2
indices.create_from 🟢 4/4 4/4
indices.get_migrate_reindex_status 🟢 1/1 1/1
indices.migrate_reindex 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit a72afb8 into main Jan 23, 2025
8 checks passed
@lcawl lcawl deleted the migration-edit branch January 23, 2025 16:52
github-actions bot pushed a commit that referenced this pull request Jan 23, 2025
lcawl added a commit that referenced this pull request Jan 23, 2025
(cherry picked from commit a72afb8)

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants