Skip to content

Change default of _create_from remove_index_blocks param to true #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

parkertimmins
Copy link
Contributor

In the _create_from API, the default value for the optional boolean parameter remove_index_blocks was changed from false to true. ES ticket: elastic/elasticsearch#120643

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
indices.create_from 🟠 Missing recording Missing recording

You can validate this API yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
indices.create_from 🟢 4/4 4/4

You can validate this API yourself by using the make validate target.

@pquentin pquentin merged commit 4bb435c into main Jan 24, 2025
8 checks passed
@pquentin pquentin deleted the create-from-change-default branch January 24, 2025 11:09
github-actions bot pushed a commit that referenced this pull request Jan 24, 2025
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 4bb435c)
pquentin pushed a commit that referenced this pull request Jan 24, 2025
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 4bb435c)

Co-authored-by: Parker Timmins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants