Skip to content

Update rest-api-spec 8.x #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Update rest-api-spec 8.x #3593

merged 1 commit into from
Feb 27, 2025

Conversation

github-actions[bot]
Copy link
Contributor

As titled.

@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-8.x branch 5 times, most recently from f5f2bd2 to f455fb4 Compare January 31, 2025 04:06
@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-8.x branch 4 times, most recently from 68155e2 to 2ff9800 Compare February 7, 2025 04:06
@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-8.x branch 4 times, most recently from 660fbd5 to c61f92f Compare February 14, 2025 04:06
@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-8.x branch from c61f92f to 0ca8df6 Compare February 19, 2025 04:06
Copy link
Contributor Author

Following you can find the validation results for the API you have changed.

API Status Request Response
async_search.submit 🟢 7/7 7/7

You can validate this API yourself by using the make validate target.

@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-8.x branch 2 times, most recently from 8c889c4 to f29e4ce Compare February 21, 2025 12:21
Copy link
Contributor Author

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.resolve_cluster 🔴 10/12 12/12
inference.update Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@l-trotta
Copy link
Contributor

l-trotta commented Feb 21, 2025

wait before merging I want to check what's wrong with indices.resolve_cluster nevermind it's about the missing timeout that we just removed, probably the flight recorder isn't up to date with this

@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-8.x branch from 5305402 to d6d0d83 Compare February 22, 2025 04:06
@github-actions github-actions bot requested a review from l-trotta February 22, 2025 04:06
@pquentin
Copy link
Member

pquentin commented Feb 24, 2025

wait before merging I want to check what's wrong with indices.resolve_cluster nevermind it's about the missing timeout that we just removed, probably the flight recorder isn't up to date with this

It's not actually about the missing timeout, but YAML test paramaters that are lists: https://github.com/elastic/elasticsearch/blob/a2f7486467ac6753a346df45052f550d8ade948b/rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/indices.resolve_cluster/10_basic_resolve_cluster.yml#L136-L149. This was fixed in elastic/elasticsearch#121315 but that was only backported to 8.18, not 8.x and 9.0. Those pull requests will fix that:

@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-8.x branch 2 times, most recently from 3fdb6f5 to c666679 Compare February 26, 2025 04:07
@github-actions github-actions bot force-pushed the automated/rest-api-spec-update-8.x branch from c666679 to 9c72d41 Compare February 27, 2025 04:07
@l-trotta l-trotta merged commit 16613a7 into 8.x Feb 27, 2025
1 check passed
@l-trotta l-trotta deleted the automated/rest-api-spec-update-8.x branch February 27, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants