Add back keep_alive to async_search.submit #3601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
l-trotta
approved these changes
Jan 24, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3601-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c3c2156ab2f5289322177c626c5264157c03dc47
# Push it to GitHub
git push --set-upstream origin backport-3601-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3601-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c3c2156ab2f5289322177c626c5264157c03dc47
# Push it to GitHub
git push --set-upstream origin backport-3601-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17Then, create a pull request where the |
pquentin
added a commit
that referenced
this pull request
Feb 20, 2025
(cherry picked from commit c3c2156) # Conflicts: # output/schema/schema-serverless.json # output/schema/schema.json # output/schema/validation-errors.json
pquentin
added a commit
that referenced
this pull request
Feb 20, 2025
(cherry picked from commit c3c2156) # Conflicts: # output/schema/schema-serverless.json # output/schema/schema.json # output/schema/validation-errors.json
pquentin
added a commit
that referenced
this pull request
Feb 20, 2025
(cherry picked from commit c3c2156) # Conflicts: # output/schema/schema-serverless.json # output/schema/schema.json # output/schema/validation-errors.json
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
pquentin
added a commit
that referenced
this pull request
Feb 20, 2025
pquentin
added a commit
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #3199. This bug was also shipped to 8.17 in #3200 and 8.x in #3201, which explains the backports. The same revert is done on the rest-api-spec side in elastic/elasticsearch#120781.
The Kibana team, specifically @lukasolson, noticed this. Thank you!