[ML] Update documentation for remote cluster client role in MlPutDatafeedRequest #3645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pquentin This PR was created from a fork this is why the validation doesn't work on it. Could you please help me to merge this PR, it only changes a parameter description. Thank you in advance! |
pquentin
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Sorry for the delay, I missed the notification. Since it's only a docs change, I ran validation locally.
❯ make validate branch=main api=ml.put_datafeed
Validating endpoints
Validating ml.put_datafeed
ml.put_datafeed request has been successfully validated!
✔ 71 out of 71 test request cases are passing.
✔ 71 out of 71 test response cases are passing.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
…feedRequest (#3645) * Update documentation for remote cluster client role in MlPutDatafeedRequest * Refactor comment formatting in MlPutDatafeedRequest for clarity * Update description for indices in schema.json to clarify remote cluster client role requirements * pretty --------- Co-authored-by: István Zoltán Szabó <[email protected]> Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit c287d34)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
…feedRequest (#3645) * Update documentation for remote cluster client role in MlPutDatafeedRequest * Refactor comment formatting in MlPutDatafeedRequest for clarity * Update description for indices in schema.json to clarify remote cluster client role requirements * pretty --------- Co-authored-by: István Zoltán Szabó <[email protected]> Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit c287d34)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
…feedRequest (#3645) * Update documentation for remote cluster client role in MlPutDatafeedRequest * Refactor comment formatting in MlPutDatafeedRequest for clarity * Update description for indices in schema.json to clarify remote cluster client role requirements * pretty --------- Co-authored-by: István Zoltán Szabó <[email protected]> Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit c287d34)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
…feedRequest (#3645) * Update documentation for remote cluster client role in MlPutDatafeedRequest * Refactor comment formatting in MlPutDatafeedRequest for clarity * Update description for indices in schema.json to clarify remote cluster client role requirements * pretty --------- Co-authored-by: István Zoltán Szabó <[email protected]> Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit c287d34)
pquentin
pushed a commit
that referenced
this pull request
Mar 14, 2025
…feedRequest (#3645) (#3919) * Update documentation for remote cluster client role in MlPutDatafeedRequest * Refactor comment formatting in MlPutDatafeedRequest for clarity * Update description for indices in schema.json to clarify remote cluster client role requirements * pretty --------- Co-authored-by: István Zoltán Szabó <[email protected]> Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit c287d34) Co-authored-by: Valeriy Khakhutskyy <[email protected]>
pquentin
pushed a commit
that referenced
this pull request
Mar 14, 2025
…feedRequest (#3645) (#3920) * Update documentation for remote cluster client role in MlPutDatafeedRequest * Refactor comment formatting in MlPutDatafeedRequest for clarity * Update description for indices in schema.json to clarify remote cluster client role requirements * pretty --------- Co-authored-by: István Zoltán Szabó <[email protected]> Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit c287d34) Co-authored-by: Valeriy Khakhutskyy <[email protected]>
pquentin
pushed a commit
that referenced
this pull request
Mar 14, 2025
…feedRequest (#3645) (#3921) * Update documentation for remote cluster client role in MlPutDatafeedRequest * Refactor comment formatting in MlPutDatafeedRequest for clarity * Update description for indices in schema.json to clarify remote cluster client role requirements * pretty --------- Co-authored-by: István Zoltán Szabó <[email protected]> Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit c287d34) Co-authored-by: Valeriy Khakhutskyy <[email protected]>
pquentin
pushed a commit
that referenced
this pull request
Mar 14, 2025
…feedRequest (#3645) (#3922) * Update documentation for remote cluster client role in MlPutDatafeedRequest * Refactor comment formatting in MlPutDatafeedRequest for clarity * Update description for indices in schema.json to clarify remote cluster client role requirements * pretty --------- Co-authored-by: István Zoltán Szabó <[email protected]> Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit c287d34) Co-authored-by: Valeriy Khakhutskyy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CCS to work in anomaly detection, both ML nodes and master nodes should have remote_cluster_client role. This PR fixes the note in the documentation.