Skip to content

Nodes.info #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 27, 2021
Merged

Nodes.info #367

merged 6 commits into from
Apr 27, 2021

Conversation

philkra
Copy link
Contributor

@philkra philkra commented Apr 22, 2021

Validated the response down to 1 error which is based on the flat_settings property. Aliasing everything will not do the trick we need a different approach to flatten everything within an object.

test: free-node_info_test_flat_settings_2_response.json.test-d.ts

"settings": {
        "action.destructive_requires_name": "false",
        "bootstrap.memory_lock": "true",
        "client.type": "node",
        "cluster.election.strategy": "supports_voting_only",
        "cluster.initial_master_nodes": "instance",
        "cluster.name": "elasticsearch-8-0-0-SNAPSHOT-rest-test",
        "cluster.routing.allocation.disk.threshold_enabled": "false",
...

@philkra philkra requested a review from delvedor April 27, 2021 10:04
@philkra philkra marked this pull request as ready for review April 27, 2021 10:04
@philkra philkra changed the title [DRAFT] Nodes.info Nodes.info Apr 27, 2021
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit b5f0908 into master Apr 27, 2021
@delvedor delvedor deleted the nodes.info-fix branch April 27, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants