Skip to content

Fix server default for include_source_on_error #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

mosche
Copy link
Contributor

@mosche mosche commented Feb 6, 2025

Fix server default for include_source_on_error

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
bulk 🟢 450/450 468/468
create 🟢 24/24 23/23
index 🟢 1154/1154 1156/1156
update 🟢 35/35 35/35

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@mosche mosche merged commit 9ac73fc into main Feb 6, 2025
13 of 14 checks passed
@mosche mosche deleted the fix_include_source_on_error_server_default branch February 6, 2025 10:53
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
pquentin pushed a commit that referenced this pull request Feb 12, 2025
(cherry picked from commit 9ac73fc)

Co-authored-by: Moritz Mack <[email protected]>
pquentin pushed a commit that referenced this pull request Feb 12, 2025
(cherry picked from commit 9ac73fc)

Co-authored-by: Moritz Mack <[email protected]>
pquentin pushed a commit that referenced this pull request Feb 12, 2025
(cherry picked from commit 9ac73fc)

Co-authored-by: Moritz Mack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants