Skip to content

Switch validate-pr to ESM #3774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Switch validate-pr to ESM #3774

merged 1 commit into from
Feb 12, 2025

Conversation

pquentin
Copy link
Member

This is required as the types-validator package in clients-flight-recorder was migrated to ESM. The CI is currently broken.

@pquentin pquentin merged commit 5263910 into main Feb 12, 2025
16 checks passed
@pquentin pquentin deleted the validate-pr-esm branch February 12, 2025 15:32
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3774-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 526391027f3f18af63bdc0ae35ef26cd846ec641
# Push it to GitHub
git push --set-upstream origin backport-3774-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3774-to-8.x.

Copy link
Contributor

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3774-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 526391027f3f18af63bdc0ae35ef26cd846ec641
# Push it to GitHub
git push --set-upstream origin backport-3774-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-3774-to-8.17.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-3774-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 526391027f3f18af63bdc0ae35ef26cd846ec641
# Push it to GitHub
git push --set-upstream origin backport-3774-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-3774-to-8.18.

github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
(cherry picked from commit 5263910)
pquentin added a commit that referenced this pull request Feb 13, 2025
(cherry picked from commit 5263910)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Feb 13, 2025
(cherry picked from commit 5263910)

# Conflicts:
#	.github/validate-pr/index.js
pquentin added a commit that referenced this pull request Feb 13, 2025
(cherry picked from commit 5263910)

# Conflicts:
#	.github/validate-pr/index.js
pquentin added a commit that referenced this pull request Feb 13, 2025
(cherry picked from commit 5263910)

# Conflicts:
#	.github/validate-pr/index.js
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x
8.18
8.17

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Feb 13, 2025
(cherry picked from commit 5263910)

# Conflicts:
#	.github/validate-pr/index.js
pquentin added a commit that referenced this pull request Feb 13, 2025
(cherry picked from commit 5263910)

# Conflicts:
#	.github/validate-pr/index.js
pquentin added a commit that referenced this pull request Feb 13, 2025
(cherry picked from commit 5263910)

# Conflicts:
#	.github/validate-pr/index.js
Copy link
Contributor

The backport to 8.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-3774-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 526391027f3f18af63bdc0ae35ef26cd846ec641
# Push it to GitHub
git push --set-upstream origin backport-3774-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16

Then, create a pull request where the base branch is 8.16 and the compare/head branch is backport-3774-to-8.16.

pquentin added a commit that referenced this pull request Feb 19, 2025
(cherry picked from commit 5263910)

# Conflicts:
#	.github/validate-pr/index.js
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.16

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Feb 19, 2025
(cherry picked from commit 5263910)

# Conflicts:
#	.github/validate-pr/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants