-
Notifications
You must be signed in to change notification settings - Fork 101
[ML] Update start model deployment & update model deployment APIs #3779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@davidkyle could you please check the backport labels? does the |
Hey @l-trotta, I saw that you added |
@rbrtj yes most of the client don't follow the DRA process, so backporting to 8.18 and 9.0 is the only way for all clients to have these fixes in those versions |
) * Update start model deployment & update model deployment apis * fix formatting (cherry picked from commit 90ea950)
) * Update start model deployment & update model deployment apis * fix formatting (cherry picked from commit 90ea950)
) * Update start model deployment & update model deployment apis * fix formatting (cherry picked from commit 90ea950)
) (#3820) * Update start model deployment & update model deployment apis * fix formatting (cherry picked from commit 90ea950) Co-authored-by: Robert Jaszczurek <[email protected]>
) (#3819) * Update start model deployment & update model deployment apis * fix formatting (cherry picked from commit 90ea950) Co-authored-by: Robert Jaszczurek <[email protected]>
) (#3818) * Update start model deployment & update model deployment apis * fix formatting (cherry picked from commit 90ea950) Co-authored-by: Robert Jaszczurek <[email protected]>
The
ml.start_trained_model_deployment
andml.update_trained_model_deployment
methods are outdated. Therefore, we currently usetransport.request
with manual type definitions: https://github.com/elastic/kibana/blob/main/x-pack/platform/plugins/shared/ml/server/lib/ml_client/ml_client.ts#L526The API has been updated to correctly accept
adaptive_allocations
settings inside the request body.