Skip to content

Switch back to properties body in put_data_lifecycle request #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

pquentin
Copy link
Member

#3039 extracted DataStreamLifecycle to avoid copying its definition twice. However, it's a breaking change, affecting Kibana. Should we revert the refactoring? The downside is that any fixes will have to be made to the two versions, and we'll certainly forget.

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
indices.put_data_lifecycle Missing test Missing test

You can validate this API yourself by using the make validate target.

@pquentin pquentin merged commit 265cd55 into main Feb 18, 2025
14 checks passed
@pquentin pquentin deleted the data-stream-lifecycle-properties branch February 18, 2025 13:54
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3787-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 265cd5572fbfdce7c16dd5c151d57ac2010624d1
# Push it to GitHub
git push --set-upstream origin backport-3787-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3787-to-8.x.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-3787-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 265cd5572fbfdce7c16dd5c151d57ac2010624d1
# Push it to GitHub
git push --set-upstream origin backport-3787-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-3787-to-8.18.

github-actions bot pushed a commit that referenced this pull request Feb 18, 2025
pquentin added a commit that referenced this pull request Feb 18, 2025
(cherry picked from commit 265cd55)

# Conflicts:
#	output/openapi/elasticsearch-serverless-openapi.json
pquentin added a commit that referenced this pull request Feb 18, 2025
(cherry picked from commit 265cd55)

# Conflicts:
#	output/openapi/elasticsearch-serverless-openapi.json
@pquentin
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x
8.18

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Feb 18, 2025
…3789)

(cherry picked from commit 265cd55)

# Conflicts:
#	output/openapi/elasticsearch-serverless-openapi.json
pquentin added a commit that referenced this pull request Feb 18, 2025
…3790)

(cherry picked from commit 265cd55)

# Conflicts:
#	output/openapi/elasticsearch-serverless-openapi.json
pquentin added a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants