Skip to content

Error type already in cause #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Error type already in cause #3826

merged 1 commit into from
Feb 24, 2025

Conversation

l-trotta
Copy link
Contributor

type is currently required in BulkIndexByScrollFailure, but it's actually never serialized there, only inside the cause field, where we already have it correctly as a required field.
Server code: BulkByScrollResponse, failures toXcontent, Exception toXcontent -> showing where type is.

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@l-trotta l-trotta merged commit 960d65a into main Feb 24, 2025
18 checks passed
@l-trotta l-trotta deleted the failures-error-type-fix branch February 24, 2025 16:42
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)
l-trotta added a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Feb 24, 2025
(cherry picked from commit 960d65a)

Co-authored-by: Laura Trotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants