-
Notifications
You must be signed in to change notification settings - Fork 102
remove LanguageAnalyzer #3859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove LanguageAnalyzer #3859
Conversation
@fbaligand thank you for the contribution! could you also remove the |
e237e43
to
36c3a55
Compare
Hi @l-trotta Thanks for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3859-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d190348790683844d972d2a3d239cdb316084f3a
# Push it to GitHub
git push --set-upstream origin backport-3859-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-3859-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d190348790683844d972d2a3d239cdb316084f3a
# Push it to GitHub
git push --set-upstream origin backport-3859-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18 Then, create a pull request where the |
* remove LanguageAnalyzer * remove Language enum (cherry picked from commit d190348)
* remove LanguageAnalyzer * remove Language enum (cherry picked from commit d190348) Co-authored-by: Fabien Baligand <[email protected]>
* remove LanguageAnalyzer * remove Language enum
* remove LanguageAnalyzer * remove Language enum
Thanks for the merge @l-trotta ! |
The "language" analyzer does not exist at least since Elasticsearch 8.
If I try to create this index:
I got this error:
That's why this PR aims to remove LanguageAnalyzer class in elasticsearch-specification.