-
Notifications
You must be signed in to change notification settings - Fork 102
Draft Watsonx inference API #3866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Laura Trotta <[email protected]>
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side. Thank you 🙂 Maybe Laura wants to double check.
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3866-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16c8bd383b6caa644ab64a57e989bb1d75b8b458
# Push it to GitHub
git push --set-upstream origin backport-3866-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-3866-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16c8bd383b6caa644ab64a57e989bb1d75b8b458
# Push it to GitHub
git push --set-upstream origin backport-3866-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18 Then, create a pull request where the |
Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit 16c8bd3)
Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit 16c8bd3)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3866-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16c8bd383b6caa644ab64a57e989bb1d75b8b458
# Push it to GitHub
git push --set-upstream origin backport-3866-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17 Then, create a pull request where the |
Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit 16c8bd3)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit 16c8bd3)
Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit 16c8bd3)
Co-authored-by: Laura Trotta <[email protected]> (cherry picked from commit 16c8bd3) Co-authored-by: Lisa Cawley <[email protected]>
Relates to #3821, elastic/elasticsearch#115088
This PR is an attempt to handle the Watsonx inference use case, with content derived from https://www.elastic.co/guide/en/elasticsearch/reference/current/infer-service-watsonx-ai.html
The following linting error occurs:
This is essentially because there are multiple paths that are interchangeable (since neither the task type nor the inference ID in the path are unique to each of these variations). We are currently treating that type of lint message as a warning, however, so if that's the best method to represent these endpoints the linting message is acceptable IMO.