Skip to content

Fix scroll Response #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions output/schema/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -32415,7 +32415,7 @@
"properties": [
{
"name": "index",
"required": true,
"required": false,
"type": {
"kind": "instance_of",
"type": {
Expand All @@ -32426,7 +32426,7 @@
},
{
"name": "node",
"required": true,
"required": false,
"type": {
"kind": "instance_of",
"type": {
Expand Down
4 changes: 2 additions & 2 deletions output/typescript/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2172,8 +2172,8 @@ export type SequenceNumber = integer
export type ShapeRelation = 'intersects' | 'disjoint' | 'within'

export interface ShardFailure {
index: IndexName
node: string
index?: IndexName
node?: string
reason: ErrorCause
shard: integer
status?: string
Expand Down
1 change: 0 additions & 1 deletion specification/_global/scroll/ScrollResponse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,5 @@
*/

import { Response as SearchResponse } from '@global/search/SearchResponse'
import { integer } from '@_types/Numeric'

export class Response<TDocument> extends SearchResponse<TDocument> {}
4 changes: 2 additions & 2 deletions specification/_types/Errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ export class MainError extends ErrorCause {
}

export class ShardFailure {
index: IndexName
node: string
index?: IndexName
node?: string
reason: ErrorCause
shard: integer
status?: string
Expand Down