Skip to content

Removing unnecessary union in node reload result #3968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

l-trotta
Copy link
Contributor

We had a redundant type in ReloadSecureSettingsResponse.ts, the server response is actually simpler than the spec mapping.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
nodes.clear_repositories_metering_archive Missing test Missing test
nodes.get_repositories_metering_info Missing test Missing test
nodes.hot_threads 🟢 5/5 5/5
nodes.info 🔴 112/112 1/112
nodes.reload_secure_settings 🟢 2/2 2/2
nodes.stats 🔴 51/51 13/51
nodes.usage 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit 8e66bce into main Mar 14, 2025
16 checks passed
@l-trotta l-trotta deleted the fix-node-reload-response branch March 14, 2025 14:54
github-actions bot pushed a commit that referenced this pull request Mar 14, 2025
(cherry picked from commit 8e66bce)
github-actions bot pushed a commit that referenced this pull request Mar 14, 2025
(cherry picked from commit 8e66bce)
github-actions bot pushed a commit that referenced this pull request Mar 14, 2025
(cherry picked from commit 8e66bce)
github-actions bot pushed a commit that referenced this pull request Mar 14, 2025
(cherry picked from commit 8e66bce)
l-trotta added a commit that referenced this pull request Mar 14, 2025
(cherry picked from commit 8e66bce)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Mar 14, 2025
(cherry picked from commit 8e66bce)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Mar 14, 2025
(cherry picked from commit 8e66bce)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Mar 14, 2025
(cherry picked from commit 8e66bce)

Co-authored-by: Laura Trotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants