Skip to content

Various schema fixes #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Various schema fixes #3973

merged 1 commit into from
Mar 18, 2025

Conversation

miguelgrinberg
Copy link
Contributor

These fixes surfaced during my request converter testing.

  • termvectors endpoint: several query parameters are also accepted as body parameters
  • esql async_query endpoint: wait_for_completion_timeout is accepted also as a body parameter
  • oidc_logout endpoint: the access_token parameter appears to be called token in this endpoint

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
esql.async_query Missing test Missing test
security.oidc_logout Missing test Missing test
termvectors 🟢 8/8 8/8

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta self-assigned this Mar 14, 2025
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
esql.async_query Missing test Missing test
security.oidc_logout Missing test Missing test
termvectors 🟢 8/8 8/8

You can validate these APIs yourself by using the make validate target.

@miguelgrinberg miguelgrinberg merged commit b2d0e64 into main Mar 18, 2025
8 checks passed
@miguelgrinberg miguelgrinberg deleted the various-schema-fixes branch March 18, 2025 15:27
github-actions bot pushed a commit that referenced this pull request Mar 18, 2025
(cherry picked from commit b2d0e64)
Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-3973-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b2d0e64812fd9bd73ac482634086e8d7190c579c
# Push it to GitHub
git push --set-upstream origin backport-3973-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-3973-to-8.18.

Copy link
Contributor

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-3973-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b2d0e64812fd9bd73ac482634086e8d7190c579c
# Push it to GitHub
git push --set-upstream origin backport-3973-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-3973-to-9.0.

miguelgrinberg added a commit that referenced this pull request Mar 18, 2025
(cherry picked from commit b2d0e64)

Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg added a commit to miguelgrinberg/elasticsearch-specification that referenced this pull request Mar 18, 2025
(cherry picked from commit b2d0e64)
miguelgrinberg added a commit that referenced this pull request Mar 18, 2025
* Various schema fixes (#3973)

(cherry picked from commit b2d0e64)

* update schema.json
miguelgrinberg added a commit to miguelgrinberg/elasticsearch-specification that referenced this pull request Mar 18, 2025
(cherry picked from commit b2d0e64)
miguelgrinberg added a commit that referenced this pull request Mar 18, 2025
Backport #3973 to 9.0
(cherry picked from commit b2d0e64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants