-
Notifications
You must be signed in to change notification settings - Fork 102
OpenAI inference request refactor + doc fix #4064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
I fixed the immediate conflict, but I suspect this refactor should apply to Azure OpenAI too: https://github.com/elastic/elasticsearch-specification/blob/main/specification/inference/put_azureopenai/PutAzureOpenAiRequest.ts |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
@pquentin found out after creating this that we want to wait to actually fix the docs, right now we want them to match the original ones, so this will be merged in the following releases |
closing as this will have too many conflicts now, will open a new one |
Avoiding exporting classes from Request files, also
chunking_settings
is only available for text embedding (not sure if that's the right way to write it, feel free to rewrite!)