-
Notifications
You must be signed in to change notification settings - Fork 102
Add ml.get_transform_stats issues in response #4065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
/** Number of times this issue has occurred since it started */ | ||
count: integer | ||
/** The timestamp this issue occurred for for the first time */ | ||
first_occurrence?: EpochTime<UnitMillis> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
around the spec I saw various instance where we also map the human readable field, so both first_occurrence
and first_occurrence_string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. We can indeed get this when passing ?human
, here are samples outputs for get_transform
{
"count": 1,
"transforms": [
{
"id": "test",
"authorization": {
"roles": [
"superuser"
]
},
"version": "10.0.0",
"create_time_string": "2025-03-26T11:25:45.642Z",
"create_time": 1742988345642,
"source": {
"index": [
"kibana_sample_data_ecommerce"
],
"query": {
"match_all": {}
}
},
"dest": {
"index": "test"
},
"pivot": {
"group_by": {
"category": {
"terms": {
"field": "category.keyword"
}
}
},
"aggregations": {
"customer_id.cardinality": {
"cardinality": {
"field": "customer_id"
}
}
}
},
"settings": {}
}
]
}
and get_transform_stats
:
{
"count": 1,
"transforms": [
{
"id": "test",
"state": "stopped",
"stats": {
"pages_processed": 2,
"documents_processed": 7409,
"documents_indexed": 6,
"documents_deleted": 0,
"trigger_count": 1,
"index_time_in_ms": 2,
"index_total": 1,
"index_failures": 0,
"search_time_in_ms": 3,
"search_total": 2,
"search_failures": 0,
"processing_time_in_ms": 0,
"processing_total": 2,
"delete_time_in_ms": 0,
"exponential_avg_checkpoint_duration_ms": 19,
"exponential_avg_documents_indexed": 6,
"exponential_avg_documents_processed": 7409
},
"checkpointing": {
"last": {
"checkpoint": 1,
"timestamp": "2025-03-26T11:25:46.849Z",
"timestamp_millis": 1742988346849
},
"changes_last_detected_at_string": "2025-03-26T11:25:46.849Z",
"changes_last_detected_at": 1742988346849
},
"health": {
"status": "green"
}
}
]
}
I fixed the ones I saw here.
They are used when `?human` is passed.
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
export class Checkpointing { | ||
changes_last_detected_at?: long | ||
changes_last_detected_at_date_time?: DateTime | ||
changes_last_detected_at_string?: DateTime | ||
last: CheckpointStats | ||
next?: CheckpointStats | ||
operations_behind?: long | ||
last_search_time?: long | ||
last_search_time_string?: DateTime | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Add ml.get_transform_stats issues in response * Add missing DateTime fields They are used when `?human` is passed. (cherry picked from commit 573e699)
* Add ml.get_transform_stats issues in response * Add missing DateTime fields They are used when `?human` is passed. (cherry picked from commit 573e699)
* Add ml.get_transform_stats issues in response * Add missing DateTime fields They are used when `?human` is passed. (cherry picked from commit 573e699)
* Add ml.get_transform_stats issues in response * Add missing DateTime fields They are used when `?human` is passed. (cherry picked from commit 573e699) Co-authored-by: Quentin Pradet <[email protected]>
* Add ml.get_transform_stats issues in response * Add missing DateTime fields They are used when `?human` is passed. (cherry picked from commit 573e699) Co-authored-by: Quentin Pradet <[email protected]>
* Add ml.get_transform_stats issues in response * Add missing DateTime fields They are used when `?human` is passed. (cherry picked from commit 573e699) Co-authored-by: Quentin Pradet <[email protected]>
This is a field that we have missed until now even though it was documented, except for type which was added in 8.8. It appeared in this YAML test today.
Regarding server code: