Skip to content

Modifies the description of PUT inference OpenAI #4066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

szabosteve
Copy link
Contributor

Overview

This PR applies these changes to the description of the PUT inference OpenAI reference docs: elastic/elasticsearch#125419

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
inference.put_openai Missing test Missing test

You can validate this API yourself by using the make validate target.

1 similar comment
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
inference.put_openai Missing test Missing test

You can validate this API yourself by using the make validate target.

@szabosteve szabosteve requested a review from lcawl March 24, 2025 13:53
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szabosteve szabosteve merged commit ae99584 into main Mar 24, 2025
8 checks passed
@szabosteve szabosteve deleted the szabosteve/openai-change branch March 24, 2025 15:48
github-actions bot pushed a commit that referenced this pull request Mar 24, 2025
Copy link
Contributor

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-4066-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ae9958471166c553322a0cf92445729027a60438
# Push it to GitHub
git push --set-upstream origin backport-4066-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-4066-to-8.17.

github-actions bot pushed a commit that referenced this pull request Mar 24, 2025
l-trotta pushed a commit that referenced this pull request Mar 27, 2025
(cherry picked from commit ae99584)

Co-authored-by: István Zoltán Szabó <[email protected]>
l-trotta pushed a commit that referenced this pull request Mar 27, 2025
(cherry picked from commit ae99584)

Co-authored-by: István Zoltán Szabó <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants