-
Notifications
You must be signed in to change notification settings - Fork 102
Fixing inference trained models #4095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. Ran out of time to review the Roberta model.
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit eeb1afb)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-4095-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eeb1afbe4e6897f5387e56ce9b2f54310d391e62
# Push it to GitHub
git push --set-upstream origin backport-4095-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-4095-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eeb1afbe4e6897f5387e56ce9b2f54310d391e62
# Push it to GitHub
git push --set-upstream origin backport-4095-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17 Then, create a pull request where the |
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit eeb1afb)
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit eeb1afb)
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit eeb1afb) Co-authored-by: Laura Trotta <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit eeb1afb) Co-authored-by: Laura Trotta <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit eeb1afb) Co-authored-by: Laura Trotta <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit eeb1afb) Co-authored-by: Laura Trotta <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit eeb1afb) Co-authored-by: Laura Trotta <[email protected]>
I see this issue in 8.17.4 SDK version, in which version precisely will it be fixed? |
Reported in elastic/elasticsearch-java#964, adding various missing fields and classes around TrainedModels. Also fixing a bug with InferenceChunkingSettings where it was wrongly extending another class.