Skip to content

[Backport 9.0] Inference: rename base type, no longer a base, grown into a property #4156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

[Backport 9.0] Inference: rename base type, no longer a base, grown into a property #4156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions specification/inference/_types/CommonTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,10 @@

import { RateLimitSetting } from '@inference/_types/Services'
import { UserDefinedValue } from '@spec_utils/UserDefinedValue'
import { RequestBase } from '@_types/Base'
import { Id } from '@_types/common'
import { float, integer, long } from '@_types/Numeric'

export class RequestChatCompletionBase extends RequestBase {
export class RequestChatCompletion {
/**
* A list of objects representing the conversation.
*/
Expand Down
4 changes: 2 additions & 2 deletions specification/inference/chat_completion_unified/UnifiedRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import { RequestChatCompletionBase } from '@inference/_types/CommonTypes'
import { RequestChatCompletion } from '@inference/_types/CommonTypes'
import { RequestBase } from '@_types/Base'
import { Id } from '@_types/common'
import { Duration } from '@_types/Time'
Expand Down Expand Up @@ -49,5 +49,5 @@ export interface Request extends RequestBase {
timeout?: Duration
}
/** @codegen_name chat_completion_request */
body: RequestChatCompletionBase
body: RequestChatCompletion
}
4 changes: 2 additions & 2 deletions specification/inference/post_eis_chat_completion/PostEisChatCompletionRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import { RequestChatCompletionBase } from '@inference/_types/CommonTypes'
import { RequestChatCompletion } from '@inference/_types/CommonTypes'
import { RequestBase } from '@_types/Base'
import { Id } from '@_types/common'
/**
Expand All @@ -44,5 +44,5 @@ export interface Request extends RequestBase {
eis_inference_id: Id
}
/** @codegen_name chat_completion_request */
body: RequestChatCompletionBase
body: RequestChatCompletion
}