-
Notifications
You must be signed in to change notification settings - Fork 102
Clarify that min_score applies to aggs #4180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. Next time, please open your pull request from a branch, not a fork, that way CI will run.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-4180-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f438f9a8c72547ee821bd2959a8b9fda7326084f
# Push it to GitHub
git push --set-upstream origin backport-4180-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
* Clarify that min_score applies to aggs Relates to elastic/elasticsearch#125882 * Run make contrib --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit f438f9a)
* Clarify that min_score applies to aggs Relates to elastic/elasticsearch#125882 * Run make contrib --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit f438f9a)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Clarify that min_score applies to aggs Relates to elastic/elasticsearch#125882 * Run make contrib --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit f438f9a) Co-authored-by: Mayya Sharipova <[email protected]>
* Clarify that min_score applies to aggs Relates to elastic/elasticsearch#125882 * Run make contrib --------- Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit f438f9a) Co-authored-by: Mayya Sharipova <[email protected]>
Relates to elastic/elasticsearch#125882
Closes #4190