Skip to content

Remove EIS APIs #4212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Remove EIS APIs #4212

merged 1 commit into from
Apr 7, 2025

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Apr 7, 2025

No description provided.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.post_eis_chat_completion 🟠 Missing type Missing type
inference.put_eis 🟠 Missing type Missing type

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@szabosteve szabosteve merged commit c542836 into main Apr 7, 2025
14 checks passed
@szabosteve szabosteve deleted the remove-eis-apis branch April 7, 2025 13:24
Copy link
Contributor

github-actions bot commented Apr 7, 2025

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-4212-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c542836a5f1966c8f70f9018779f9934a81d2118
# Push it to GitHub
git push --set-upstream origin backport-4212-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-4212-to-8.x.

Copy link
Contributor

github-actions bot commented Apr 7, 2025

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-4212-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c542836a5f1966c8f70f9018779f9934a81d2118
# Push it to GitHub
git push --set-upstream origin backport-4212-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-4212-to-8.18.

github-actions bot pushed a commit that referenced this pull request Apr 7, 2025
(cherry picked from commit c542836)
pquentin added a commit that referenced this pull request Apr 7, 2025
(cherry picked from commit c542836)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Apr 7, 2025
(cherry picked from commit c542836)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
#	specification/inference/post_eis_chat_completion/PostEisChatCompletionResponse.ts
@pquentin
Copy link
Member Author

pquentin commented Apr 7, 2025

💔 Some backports could not be created

Status Branch Result
8.x
8.18 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 4212

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Apr 7, 2025
(cherry picked from commit c542836)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
#	specification/inference/post_eis_chat_completion/PostEisChatCompletionResponse.ts
#	specification/inference/put_eis/PutEisResponse.ts
@pquentin
Copy link
Member Author

pquentin commented Apr 7, 2025

💚 All backports created successfully

Status Branch Result
8.18

Questions ?

Please refer to the Backport tool documentation

szabosteve pushed a commit that referenced this pull request Apr 7, 2025
(cherry picked from commit c542836)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
#	specification/inference/post_eis_chat_completion/PostEisChatCompletionResponse.ts
szabosteve pushed a commit that referenced this pull request Apr 7, 2025
(cherry picked from commit c542836)

# Conflicts:
#	output/schema/schema-serverless.json
#	output/schema/schema.json
#	specification/inference/post_eis_chat_completion/PostEisChatCompletionResponse.ts
#	specification/inference/put_eis/PutEisResponse.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants