-
Notifications
You must be signed in to change notification settings - Fork 102
fix: AsyncQueryResponse
's body
should be AsyncEsqlResult
and not EsqlResult
#4257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AsyncQueryResponse
's body
should be AsyncEsqlResult
and not EsqlResult
#4257
Conversation
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-4257-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fea1bf8d8b64746cf69d5dd21412e2d0ee666876
# Push it to GitHub
git push --set-upstream origin backport-4257-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-4257-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fea1bf8d8b64746cf69d5dd21412e2d0ee666876
# Push it to GitHub
git push --set-upstream origin backport-4257-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-4257-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fea1bf8d8b64746cf69d5dd21412e2d0ee666876
# Push it to GitHub
git push --set-upstream origin backport-4257-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18 Then, create a pull request where the |
(cherry picked from commit fea1bf8)
(cherry picked from commit fea1bf8) Co-authored-by: Pawan Kartik <[email protected]>
took a look at the state of esql.async in the 8.x, 8.18, 8.17 branches and decided not to backport, the main reason we defined async response types is for docs purposes, while clients will handle the result in the generators, so the important thing is that this is in main and 9.0. also we're missing other backports from old PRs, so skipping this backport too. |
Based on the documentation here: https://www.elastic.co/guide/en/elasticsearch/reference/current/esql-async-query-api.html#esql-async-query-api-response-body, async query response's body type should be
AsyncEsqlResult
rather thanEsqlResult
. This allows accounting for theid
andis_running
details that are returned by the API.