-
Notifications
You must be signed in to change notification settings - Fork 102
[DOCS] Add overlays to work around deployment failure #4285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
2 similar comments
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🦖
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4285-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 157b1c66e3ee086c30ecdd93ab51f9e36cd56adf
# Push it to GitHub
git push --set-upstream origin backport-4285-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0 Then, create a pull request where the |
(cherry picked from commit 157b1c6)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Hi Lisa, We've successfully applied a bugfix today to solve the underlying issue you had lately on the elasticsearch deployments on Bump.sh. It should make this current hack obsolete, could you try it out again without this overlay? I'm here if you need anything. Have a nice day! |
Thanks! Created #4296 to remove the overlay |
Fixes #4284
Note: If we find the magic combination of objects that must be abbreviated IMO we should ultimately get this detail pushed into the specification otherwise we'll break again if the specification once again changes. Overlays are fragile.