Skip to content

[DOCS] Add overlays to work around deployment failure #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 16, 2025
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 16, 2025

Fixes #4284

Note: If we find the magic combination of objects that must be abbreviated IMO we should ultimately get this detail pushed into the specification otherwise we'll break again if the specification once again changes. Overlays are fragile.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
search 🔴 2310/2395 2378/2379

You can validate these APIs yourself by using the make validate target.

2 similar comments
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
search 🔴 2310/2395 2378/2379

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
search 🔴 2310/2395 2378/2379

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl requested a review from a team April 16, 2025 15:54
@lcawl lcawl marked this pull request as ready for review April 16, 2025 15:54
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
search 🔴 2310/2395 2378/2379

You can validate these APIs yourself by using the make validate target.

Copy link

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦖

@lcawl lcawl merged commit 157b1c6 into main Apr 16, 2025
8 checks passed
@lcawl lcawl deleted the deployment-fix branch April 16, 2025 15:57
Copy link
Contributor

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4285-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 157b1c66e3ee086c30ecdd93ab51f9e36cd56adf
# Push it to GitHub
git push --set-upstream origin backport-4285-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-4285-to-9.0.

@lcawl
Copy link
Contributor Author

lcawl commented Apr 16, 2025

💚 All backports created successfully

Status Branch Result
9.0

Questions ?

Please refer to the Backport tool documentation

@paulRbr
Copy link

paulRbr commented Apr 17, 2025

Hi Lisa,

We've successfully applied a bugfix today to solve the underlying issue you had lately on the elasticsearch deployments on Bump.sh. It should make this current hack obsolete, could you try it out again without this overlay?

I'm here if you need anything. Have a nice day!
👋

@lcawl
Copy link
Contributor Author

lcawl commented Apr 22, 2025

We've successfully applied a bugfix today to solve the underlying issue you had lately on the elasticsearch deployments on Bump.sh. It should make this current hack obsolete, could you try it out again without this overlay?

Thanks! Created #4296 to remove the overlay

lcawl added a commit that referenced this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Add overlays to work around deployment failure
3 participants