Skip to content

Synonyms API - Add refresh parameter #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025

Conversation

carlosdelest
Copy link
Member

Following elastic/elasticsearch#126935, we will be adding a refresh parameter to the following Synonyms API requests:

  • Update synonyms set
  • Update synonym rule
  • Delete synonym rule

When refresh is false, the reload analyzer details will not be present in the responses - they have been updated accordingly.

@carlosdelest carlosdelest added enhancement specification skip-backport This pull request should not be backported labels Apr 23, 2025
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 28/28 28/28

You can validate these APIs yourself by using the make validate target.

@carlosdelest carlosdelest requested a review from a team April 24, 2025 05:50
@carlosdelest carlosdelest merged commit 2843115 into main Apr 25, 2025
11 of 14 checks passed
@carlosdelest carlosdelest deleted the enhancement/synonyms-api-refresh-param branch April 25, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement skip-backport This pull request should not be backported specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants