Skip to content

Change InnerHits.fields from Fields to Field[] #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Change InnerHits.fields from Fields to Field[] #4312

merged 1 commit into from
Apr 28, 2025

Conversation

flobernd
Copy link
Member

Related to: elastic/elasticsearch-net#8503

Fields was never the correct type.

@flobernd flobernd requested review from l-trotta and a team April 28, 2025 12:15
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 2312/2397 2380/2381

You can validate this API yourself by using the make validate target.

@l-trotta
Copy link
Contributor

confirmed, LGTM!

@flobernd flobernd merged commit 54dba79 into main Apr 28, 2025
12 of 16 checks passed
@flobernd flobernd deleted the fix-inner-hits-fields branch April 28, 2025 17:56
github-actions bot pushed a commit that referenced this pull request Apr 28, 2025
@flobernd @github-actions
Change InnerHits.fields from Fields to Field[] (#4312)
2f13aa6 
(cherry picked from commit 54dba79)
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Apr 28, 2025
@flobernd @github-actions
Change InnerHits.fields from Fields to Field[] (#4312)
244e692 
(cherry picked from commit 54dba79)
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Apr 28, 2025
@flobernd @github-actions
Change InnerHits.fields from Fields to Field[] (#4312)
a9bf147 
(cherry picked from commit 54dba79)
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Merged
flobernd added a commit that referenced this pull request Apr 28, 2025
@github-actions @flobernd
Change InnerHits.fields from Fields to Field[] (#4312) (#4317)
03b6c96 
(cherry picked from commit 54dba79)

Co-authored-by: Florian Bernd <[email protected]>
flobernd added a commit that referenced this pull request Apr 28, 2025
@github-actions @flobernd
Change InnerHits.fields from Fields to Field[] (#4312) (#4318)
2e44f91 
(cherry picked from commit 54dba79)

Co-authored-by: Florian Bernd <[email protected]>
flobernd added a commit that referenced this pull request Apr 28, 2025
@github-actions @flobernd
Change InnerHits.fields from Fields to Field[] (#4312) (#4319)
d7e5a83 
(cherry picked from commit 54dba79)

Co-authored-by: Florian Bernd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-trotta l-trotta l-trotta approved these changes

Assignees
No one assigned
Labels
backport 8.18 backport 8.19 backport 9.0 bug specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flobernd @l-trotta