Skip to content

Reorg mtermvectors #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 5, 2021
Merged

Reorg mtermvectors #440

merged 5 commits into from
May 5, 2021

Conversation

stevejgordon
Copy link
Contributor

Contributes to #409

@delvedor - I've moved some of the types from termvectors/types.ts into _types/termvectors/TermVector.ts since those are reused across mtermvectors and termvectors APIs. Is that the correct approach here?

delvedor
delvedor requested changes May 5, 2021
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would follow the same approach as mget and msearch and leave the base types in termvectors/types.ts and reuse them in mtermvectors. The rest of the changes looks good!

@stevejgordon stevejgordon force-pushed the stevejgordon/fix-409-mtermvectors branch from 5949b14 to ecc28ac Compare May 5, 2021 12:50
@stevejgordon
Copy link
Contributor Author

@delvedor Done! I've moved TermVectorsResult under mtermvectors as it's only used there.

@stevejgordon stevejgordon requested a review from delvedor May 5, 2021 12:57
delvedor
delvedor approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit e97c726 into master May 5, 2021
@delvedor delvedor deleted the stevejgordon/fix-409-mtermvectors branch May 5, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevejgordon @delvedor