Skip to content

Correct map types #4469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

Correct map types #4469

merged 2 commits into from
Jun 6, 2025

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Jun 5, 2025

@l-trotta l-trotta added the skip-backport This pull request should not be backported label Jun 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 2348/2423 2406/2407

You can validate this API yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Following you can find the validation results for the API you have changed.

API Status Request Response
search 🔴 2348/2423 2406/2407

You can validate this API yourself by using the make validate target.

pquentin
pquentin approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. We agreed offline that this breaking change was worth it for 9.1.

@l-trotta l-trotta merged commit 49d8131 into main Jun 6, 2025
8 checks passed
@l-trotta l-trotta deleted the correct-maps-types branch June 6, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
skip-backport This pull request should not be backported specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l-trotta @pquentin