Skip to content

Allow empty object responses #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 10, 2021
Merged

Allow empty object responses #451

merged 4 commits into from
May 10, 2021

Conversation

delvedor
Copy link
Member

@delvedor delvedor commented May 6, 2021

#444 surfaced a bug, where we aren't allowing empty object responses, which some security APIs are using.
It would be nice to see those APIs migrate to the AcknowledgedResponseBase tho.

Related: #450

Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit 9ceb90f into master May 10, 2021
@delvedor delvedor deleted the fix-response-compiler branch May 10, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants