-
Notifications
You must be signed in to change notification settings - Fork 102
add language client examples to YAML files #4514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
70c5c8c
to
22cba50
Compare
22cba50
to
bc6bcf2
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
2fda1e5
to
e5f9db2
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
92cd84a
to
93c7137
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
0a662bc
to
151b516
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
1 similar comment
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
151b516
to
d76bc1c
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
2 similar comments
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
d76bc1c
to
06d9601
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spot-checked a few examples and tested a curl example and overall LGTM.
One thing to consider, since we're using some variables like this:
curl -X GET -H "Authorization: ApiKey $ELASTIC_API_KEY" "http://localhost:9200/_alias"
Should we use them for the hostname and port number too? It took me a few minutes to notice that it was "http" instead of "https" while I was testing.
@lcawl ah yes, I'm doing this all the time and I think I'm now sort of blind wrt this type of detail. I can change the generated examples to use env vars as well. Thanks! |
should we write somewhere that now |
06d9601
to
fb60893
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4514-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d4d6059aad14c30ed1fd007c8262410046fb5d00
# Push it to GitHub
git push --set-upstream origin backport-4514-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0 Then, create a pull request where the |
* expand model to include language versions of examples * add language client examples to YAML files * use $ELASTICSEARCH_URL in curl examples * remove unnecessary generate-language-examples task from the openapi generation * upgrade request converter to latest
* expand model to include language versions of examples * add language client examples to YAML files * use $ELASTICSEARCH_URL in curl examples * remove unnecessary generate-language-examples task from the openapi generation * upgrade request converter to latest
* expand model to include language versions of examples * add language client examples to YAML files * use $ELASTICSEARCH_URL in curl examples * remove unnecessary generate-language-examples task from the openapi generation * upgrade request converter to latest
* expand model to include language versions of examples * add language client examples to YAML files * use $ELASTICSEARCH_URL in curl examples * remove unnecessary generate-language-examples task from the openapi generation * upgrade request converter to latest
Relates to #3915
This change adds all the language variations to YAML example files. There is a new command:
to refresh all YAML files with up to date examples for all available languages (currently Ruby, PHP, JS, Python and curl). This command is invoked automatically when you run
make generate
.Note to reviewers: It should be much easier to review the first commit in this PR separately from the second. The second commit has the updated yaml files for all examples, it is a huge diff that you probably don't need to see while reviewing the logic changes.