Skip to content

Bump ts-morph version #4524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025
Merged

Bump ts-morph version #4524

merged 2 commits into from
Jun 12, 2025

Conversation

pquentin
Copy link
Member

This fixes errors like this:

> [email protected] build                                                                                                                                                                           
> rm -rf lib && tsc                                                                                                                                                                                                        
                                                                                                                                                                                                                           
tsconfig.json:19:5 - error TS5102: Option 'suppressImplicitAnyIndexErrors' has been removed. Please remove it from your configuration.                                                                                     

19     "suppressImplicitAnyIndexErrors": true,
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and this:

> [email protected] build                                                                                                                                                                           
> rm -rf lib && tsc                                                                                                                                                                                                        
                                                                                                                                                                                                                           
node_modules/ts-morph/lib/ts-morph.d.ts:5454:127 - error TS2344: Type 'CompilerNodeToWrappedType<InstanceOf<T>["compilerNode"]>' does not satisfy the constraint 'Node<Node>'.                                             
  Type 'SourceFile | ImportDeclaration | ExportDeclaration | ImportEqualsDeclaration | Identifier | ... 192 more ... | Node<...>' is not assignable to type 'Node<Node>'.
    Type 'SourceFile' is not assignable to type 'Node<Node>'.
      The types returned by 'forgetDescendants()' are incompatible between these types.
        Type 'SourceFile' is not assignable to type 'CompilerNodeToWrappedType<InstanceOf<T>["compilerNode"]>'.

5454 export declare function BaseExpressionedNode<T extends Constructor<ExpressionedNodeExtensionType>, TExpression extends Node = CompilerNodeToWrappedType<InstanceOf<T>["compilerNode"]>>(Base: T): Constructor<BaseExpressionedNode<TExpression>> & T;
                                                                                                                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 1 error in node_modules/ts-morph/lib/ts-morph.d.ts:5454

@pquentin pquentin merged commit 79ff7e3 into main Jun 12, 2025
10 checks passed
@pquentin pquentin deleted the bump-ts-morph branch June 12, 2025 15:05
github-actions bot pushed a commit that referenced this pull request Jun 12, 2025
* Bump ts-morph version

* Fix typescript-generator too

(cherry picked from commit 79ff7e3)
Copy link
Contributor

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-4524-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 79ff7e34435ca6d04c27e2f893aa9b31ba50271d
# Push it to GitHub
git push --set-upstream origin backport-4524-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-4524-to-8.17.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-4524-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 79ff7e34435ca6d04c27e2f893aa9b31ba50271d
# Push it to GitHub
git push --set-upstream origin backport-4524-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-4524-to-8.18.

Copy link
Contributor

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4524-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 79ff7e34435ca6d04c27e2f893aa9b31ba50271d
# Push it to GitHub
git push --set-upstream origin backport-4524-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-4524-to-9.0.

pquentin added a commit that referenced this pull request Jun 13, 2025
* Bump ts-morph version

* Fix typescript-generator too

(cherry picked from commit 79ff7e3)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Jun 13, 2025
* Bump ts-morph version

* Fix typescript-generator too

(cherry picked from commit 79ff7e3)

# Conflicts:
#	compiler/package-lock.json
pquentin added a commit that referenced this pull request Jun 13, 2025
* Bump ts-morph version

* Fix typescript-generator too

(cherry picked from commit 79ff7e3)

# Conflicts:
#	compiler/package-lock.json
@pquentin
Copy link
Member Author

💔 Some backports could not be created

Status Branch Result
9.0
8.18
8.17 Conflict resolution was aborted by the user

Manual backport

To create the backport manually run:

backport --pr 4524

Questions ?

Please refer to the Backport tool documentation

pquentin added a commit that referenced this pull request Jun 13, 2025
* Bump ts-morph version

* Fix typescript-generator too

(cherry picked from commit 79ff7e3)

# Conflicts:
#	compiler/package-lock.json
pquentin added a commit that referenced this pull request Jun 13, 2025
* Bump ts-morph version

* Fix typescript-generator too

(cherry picked from commit 79ff7e3)

# Conflicts:
#	compiler/package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants