Skip to content

Fix required properties #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2021
Merged

Fix required properties #615

merged 2 commits into from
Aug 30, 2021

Conversation

delvedor
Copy link
Member

This pr fixes a bunch of path_parts that should be required.

This change will break the validation for security.clear_api_key_cache, our test are sending requests without ids, but in both docs and rest-api-spec ids is required.

@delvedor delvedor requested a review from a team August 30, 2021 10:23
sethmlarson
sethmlarson approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

swallez
swallez reviewed Aug 30, 2021
View reviewed changes
@delvedor delvedor merged commit 45c1839 into main Aug 30, 2021
@delvedor delvedor deleted the fix-put-mapping branch August 30, 2021 12:53
github-actions bot pushed a commit that referenced this pull request Aug 30, 2021
@delvedor @github-actions
Fix required properties (#615)
69aab8f
@github-actions github-actions bot mentioned this pull request Aug 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swallez swallez swallez left review comments

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delvedor @swallez @sethmlarson