Fix addDescription step #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@delvedor we also discussed collecting the missing description in a log file to forward to the docs team. I think we should open an issue to track this improvement, WDYT? |
|
I'm not against creating such file, but I think is useless, at least for now. We are missing the descriptions for so many parameters that it would be a massive logfile that no one will read. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates the
addDescriptionstep of the compiler which wasn't updated with the last iteration of the spec.Now, if a path or query parameter does not contain a description in the input specification, the description will be pulled from the rest-api-spec.