Fix stubbed rollup API #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvedor
requested changes
Sep 1, 2021
|
@delvedor I did do before submitting. Have run again and it's not modified any files? |
|
Try to merge main in your working branch. |
stevejgordon
force-pushed
the
fix/rollup-api
branch
from
01e3d45 to
526f8cb
Compare
|
Rebased and pushed |
delvedor
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this API is not documented, quite complex, and experimental, we have agreed to treat the request and response body as
UserDefinedValuefor now. I'm awaiting some feedback from the Elasticsearch engineers to understand if this API is valid still.