Skip to content

[Backport 7.x] Fix stubbed rollup API #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2021
Merged

[Backport 7.x] Fix stubbed rollup API #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 18 additions & 37 deletions output/schema/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9204,7 +9204,7 @@
"namespace": "rollup.rollup"
},
"since": "7.13.0",
"stability": "TODO",
"stability": "experimental",
"urls": [
{
"methods": [
Expand Down Expand Up @@ -124037,20 +124037,10 @@
"CommonQueryParameters"
],
"body": {
"kind": "properties",
"properties": [
{
"name": "stub",
"required": true,
"type": {
"kind": "instance_of",
"type": {
"name": "integer",
"namespace": "_types"
}
}
}
]
"kind": "value",
"value": {
"kind": "user_defined_value"
}
},
"inherits": {
"type": {
Expand All @@ -124065,47 +124055,38 @@
},
"path": [
{
"name": "stubb",
"description": "The index to roll up",
"name": "index",
"required": true,
"type": {
"kind": "instance_of",
"type": {
"name": "integer",
"name": "IndexName",
"namespace": "_types"
}
}
}
],
"query": [
},
{
"name": "stuba",
"description": "The name of the rollup index to create",
"name": "rollup_index",
"required": true,
"type": {
"kind": "instance_of",
"type": {
"name": "integer",
"name": "IndexName",
"namespace": "_types"
}
}
}
]
],
"query": []
},
{
"body": {
"kind": "properties",
"properties": [
{
"name": "stub",
"required": true,
"type": {
"kind": "instance_of",
"type": {
"name": "integer",
"namespace": "_types"
}
}
}
]
"kind": "value",
"value": {
"kind": "user_defined_value"
}
},
"kind": "response",
"name": {
Expand Down
6 changes: 0 additions & 6 deletions output/schema/validation-errors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,12 +1351,6 @@
],
"response": []
},
"rollup.rollup": {
"request": [
"Endpoint has \"@stability: TODO"
],
"response": []
},
"rollup.start_job": {
"request": [
"Endpoint has \"@stability: TODO"
Expand Down
12 changes: 4 additions & 8 deletions output/typescript/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12773,16 +12773,12 @@ export interface RollupPutJobResponse extends AcknowledgedResponseBase {
}

export interface RollupRollupRequest extends RequestBase {
stubb: integer
stuba: integer
body?: {
stub: integer
}
index: IndexName
rollup_index: IndexName
body?: any
}

export interface RollupRollupResponse {
stub: integer
}
export type RollupRollupResponse = any

export interface RollupRollupSearchRequest extends RequestBase {
index: Indices
Expand Down
15 changes: 6 additions & 9 deletions specification/rollup/rollup/RollupRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,19 @@
* under the License.
*/

import { UserDefinedValue } from '@spec_utils/UserDefinedValue'
import { RequestBase } from '@_types/Base'
import { integer } from '@_types/Numeric'
import { IndexName } from '@_types/common'

/**
* @rest_spec_name rollup.rollup
* @since 7.13.0
* @stability TODO
* @stability experimental
*/
export interface Request extends RequestBase {
path_parts?: {
stubb: integer
}
query_parameters?: {
stuba: integer
}
body?: {
stub: integer
index: IndexName
rollup_index: IndexName
}
body?: UserDefinedValue // TODO: This API is experimental and no docs exist describing it. Requires reverse engineering if made stable
}
4 changes: 2 additions & 2 deletions specification/rollup/rollup/RollupResponse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
* under the License.
*/

import { integer } from '@_types/Numeric'
import { UserDefinedValue } from '@spec_utils/UserDefinedValue'

export class Response {
body: { stub: integer }
body: UserDefinedValue // TODO: This API is experimental and no docs exist describing it. Requires reverse engineering if made stable
}