-
Notifications
You must be signed in to change notification settings - Fork 102
Add documentation on spec documentation #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
API endpoints will also have a `@doc_url` JSDoc tag that links to that API's detailed documentation page. | ||
|
||
### Multi-paragraph doc comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we merge the content with this section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a commit that that adds a link to this document in that section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @swallez 👍
Appreciate the documentation. The writing advice re: how to structure annotations to be succinct, contain a descriptive line before substantial paragraphs, is also appreciated. It is a step forward to a standard we can adopt across many contexts when generating API docs.
Pinging writers from Elasticsearch: @debadair @jrodewig @lockewritesdocs
And writers with a general interest in API docs: @KOTungseth @lcawl @kilfoyle
Folks: this PR documents how the API specifications now support GitHub Flavoured Markdown. These annotated TypeScript API specifications render down into JSON which an eventual "next docs" generator will turn into MDX doc pages. Happy to unpack in greater detail and no action is required, but feel free to leave feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should also add a check in the compiler to verify if the description
can be parsed with GFM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ documentation about how to write documentation ✍🏻 .
Co-authored-by: Greg Back <[email protected]>
Adds a doc explaining how to write and structure JSDoc documentation in the specification.
@goodroot I added you as a reviewer, feel free to add more people from the docs team to raise awareness and provide feedback.