Skip to content

Add documentation on spec documentation #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2021
Merged

Add documentation on spec documentation #638

merged 3 commits into from
Sep 9, 2021

Conversation

swallez
Copy link
Member

@swallez swallez commented Sep 1, 2021

Adds a doc explaining how to write and structure JSDoc documentation in the specification.

@goodroot I added you as a reviewer, feel free to add more people from the docs team to raise awareness and provide feedback.

@swallez swallez requested review from goodroot and a team September 1, 2021 17:15

API endpoints will also have a `@doc_url` JSDoc tag that links to that API's detailed documentation page.

### Multi-paragraph doc comments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge the content with this section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit that that adds a link to this document in that section.

Copy link

@goodroot goodroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swallez 👍

Appreciate the documentation. The writing advice re: how to structure annotations to be succinct, contain a descriptive line before substantial paragraphs, is also appreciated. It is a step forward to a standard we can adopt across many contexts when generating API docs.

Pinging writers from Elasticsearch: @debadair @jrodewig @lockewritesdocs

And writers with a general interest in API docs: @KOTungseth @lcawl @kilfoyle

Folks: this PR documents how the API specifications now support GitHub Flavoured Markdown. These annotated TypeScript API specifications render down into JSON which an eventual "next docs" generator will turn into MDX doc pages. Happy to unpack in greater detail and no action is required, but feel free to leave feedback.

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should also add a check in the compiler to verify if the description can be parsed with GFM.

Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ documentation about how to write documentation ✍🏻 .

@swallez swallez merged commit b56f904 into main Sep 9, 2021
@swallez swallez deleted the add-docs-docs branch September 9, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants