Skip to content

Add variants to analysis classes, Add IndexState.data_stream #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Sep 10, 2021

Most of this is adding @variant to analyzers, tokenizers, token filters and char filters.

Added IndexState.data_stream? to close #532

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! ❤️

@sebelga
Copy link

sebelga commented Sep 23, 2021

@sethmlarson You closed #532 for the IndexState.data_stream but I am not seeing the missing settings.index.hidden as part of this PR. Is this correct?

@sethmlarson
Copy link
Contributor Author

@sebelga Hmm, I saw @aliases index.hidden on the hidden property and figured that solved the issue. @delvedor is that sufficient for this case or does more need to be done to make this value accessible?

@delvedor
Copy link
Member

It looks correct to me, @sebelga can you elaborate?

hidden?: boolean | string
'index.hidden'?: boolean | string

If what you mean is that it's not currently present in the kibana ES client, you are right, a type release has not happened yet.

@sebelga
Copy link

sebelga commented Sep 28, 2021

Oh I see it got added in a previous PR. Thanks @delvedor

l-trotta added a commit that referenced this pull request Feb 19, 2024
* added 'remove_binary' to AttachmentProcessor (issue #727)

* making node info path optional (issue #242)

* making node info discover seed_host optional (issue #242)

* changed description for update by query  (issue #315)

* adding custom options to index settings similarity (issue #299)

* initial_master_nodes from string to string[] (issue #242)

* correct contrib

* correct node info discover class (issue #242)
l-trotta added a commit that referenced this pull request Feb 19, 2024
* added 'remove_binary' to AttachmentProcessor (issue #727)

* making node info path optional (issue #242)

* making node info discover seed_host optional (issue #242)

* changed description for update by query  (issue #315)

* initial_master_nodes from string to string[] (issue #242)

* correct node info discover class (issue #242)

* generate and contrib
l-trotta added a commit that referenced this pull request Feb 19, 2024
* added 'remove_binary' to AttachmentProcessor (issue #727)

* making node info path optional (issue #242)

* making node info discover seed_host optional (issue #242)

* changed description for update by query  (issue #315)

* adding custom options to index settings similarity (issue #299)

* initial_master_nodes from string to string[] (issue #242)

* correct contrib

* correct node info discover class (issue #242)
l-trotta added a commit that referenced this pull request Feb 19, 2024
* Batch from java issues (#2412)

* added 'remove_binary' to AttachmentProcessor (issue #727)

* making node info path optional (issue #242)

* making node info discover seed_host optional (issue #242)

* changed description for update by query  (issue #315)

* adding custom options to index settings similarity (issue #299)

* initial_master_nodes from string to string[] (issue #242)

* correct contrib

* correct node info discover class (issue #242)

* contrib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing TS types for hidden setting and data stream property on Get indices response
3 participants