Skip to content

Update /welcome-to-elastic link in AWS firehose docs #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Update /welcome-to-elastic link in AWS firehose docs #3231

merged 1 commit into from
Sep 13, 2023

Conversation

jrodewig
Copy link
Contributor

Problem: In elastic/docs#2752, we updated the URL prefix (welcome-to-elastic) and name for the "Welcome to Elastic Docs" docs. However, we still have some stray links that use the old /welcome-to-elastic URL prefix

Solution: Replace an outdated link with one that uses an attribute.

@github-actions
Copy link
Contributor

A documentation preview will be available soon:

@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2023

This pull request does not have a backport label. Could you fix it @jrodewig? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 13, 2023
@jrodewig jrodewig marked this pull request as ready for review September 13, 2023 14:12
@jrodewig jrodewig requested a review from a team as a code owner September 13, 2023 14:12
@jrodewig
Copy link
Contributor Author

No backport needed here — The AWS firehose docs only build on main.

@jrodewig jrodewig enabled auto-merge (squash) September 13, 2023 15:05
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you.

@jrodewig jrodewig merged commit da28d9f into elastic:main Sep 13, 2023
@jrodewig jrodewig deleted the update-welcome-to-elastic-link branch September 13, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants