Skip to content

[DOCS] Adjusts note on minimum node size for ELSER and third-party models #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Jun 22, 2023

Overview

This PR:

  • adjusts the note on the minimum ML node size on the ELSER page to include reference to ESS and autoscaling,
  • adds the same note to the third-party models page.

Preview

@szabosteve szabosteve added :ml nlp v8.8.0 ELSER backport-8.8 Automated backport with mergify v8.9.0 backport-8.9 Automated backport with mergify v8.10 labels Jun 22, 2023
@github-actions
Copy link

Documentation preview:

@szabosteve szabosteve requested a review from dimkots June 22, 2023 15:13
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don’t have to use my exact suggested words if there’s a better way to say it, but hopefully you get the gist.

Please make the same adjustments to the other file too.

@szabosteve szabosteve requested a review from droberts195 June 23, 2023 11:00
Copy link

@dimkots dimkots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you could just fix a few typos before merging

@szabosteve szabosteve merged commit 368121a into elastic:main Jun 23, 2023
@szabosteve szabosteve deleted the rec.node.auto branch June 23, 2023 14:54
mergify bot pushed a commit that referenced this pull request Jun 23, 2023
…dels (#2447)

Co-authored-by: David Roberts <[email protected]>
(cherry picked from commit 368121a)
mergify bot pushed a commit that referenced this pull request Jun 23, 2023
…dels (#2447)

Co-authored-by: David Roberts <[email protected]>
(cherry picked from commit 368121a)
szabosteve added a commit that referenced this pull request Jun 23, 2023
…dels (#2447) (#2448)

Co-authored-by: David Roberts <[email protected]>
(cherry picked from commit 368121a)

Co-authored-by: István Zoltán Szabó <[email protected]>
szabosteve added a commit that referenced this pull request Jun 23, 2023
…dels (#2447) (#2449)

Co-authored-by: David Roberts <[email protected]>
(cherry picked from commit 368121a)

Co-authored-by: István Zoltán Szabó <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify ELSER :ml nlp v8.8.0 v8.9.0 v8.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants