Skip to content

Gke on prem integration stack docs issue 255 #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 12, 2019
Merged

Gke on prem integration stack docs issue 255 #284

merged 9 commits into from
Apr 12, 2019

Conversation

DanRoscigno
Copy link
Contributor

These docs support the integration between GKE On-Prem and the Elastic Stack.

@DanRoscigno
Copy link
Contributor Author

@lcawl I submitted the PR.

@DanRoscigno DanRoscigno requested review from lcawl and asawariS April 9, 2019 16:37
@asawariS
Copy link

Thanks @DanRoscigno I don't need to be a reviewer on this. I assume this has gone through a tech review, perhaps with someone from Ingest team?

@DanRoscigno DanRoscigno removed the request for review from asawariS April 11, 2019 14:30
@DanRoscigno
Copy link
Contributor Author

Yes @asawariS , it has been reviewed by engineering and Jamie.

@asawariS
Copy link

thanks @DanRoscigno. If @lcawl is good with it, let's ship it.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds successfully

@DanRoscigno DanRoscigno merged commit ddd2753 into elastic:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants