Fix metric_custom_indicator's good and total metrics array
#545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
reviewed
Jan 29, 2024
| @@ -541,6 +542,17 @@ func getSloFromResourceData(d *schema.ResourceData) (models.Slo, diag.Diagnostic | |||
| } | |||
|
|
|||
| case "metric_custom_indicator": | |||
| goodMetricsRaw := d.Get(indicatorType + ".0.good.0.metrics").([]interface{}) | |||
There was a problem hiding this comment.
It seems that in the SLO UI the total can also accept an array of metrics. Should we also support an array of metrics for it?
cnasikas
previously approved these changes
Jan 29, 2024
jloleysens
commented
Jan 29, 2024
This reverts commit ef01b30.
|
@wandergeek are you able to take a look over this one? |
jloleysens
commented
Jan 30, 2024
| indicator = slo.SloResponseIndicator{ | ||
| IndicatorPropertiesCustomMetric: &slo.IndicatorPropertiesCustomMetric{ | ||
| Type: indicatorAddressToType[indicatorType], | ||
| Params: slo.IndicatorPropertiesCustomMetricParams{ | ||
| Filter: getOrNilString(indicatorType+".0.filter", d), | ||
| Index: d.Get(indicatorType + ".0.index").(string), | ||
| TimestampField: d.Get(indicatorType + ".0.timestamp_field").(string), | ||
| Total: slo.IndicatorPropertiesCustomMetricParamsTotal{ | ||
| Equation: d.Get(indicatorType + ".0.total.0.equation").(string), | ||
| Metrics: []slo.IndicatorPropertiesCustomMetricParamsTotalMetricsInner{ //are there actually instances where there are more than one 'good' / 'total'? Need to build array if so. |
jloleysens
changed the title
metric_custom_indicator's good metrics arraymetric_custom_indicator's good and total metrics array
wandergeek
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the all metrics specified in the array are applied to the SLO resource
Close #544