Skip to content

Fixup data views in 8.14 #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Fixup data views in 8.14 #663

merged 5 commits into from
Jun 12, 2024

Conversation

tobio
Copy link
Member

@tobio tobio commented Jun 12, 2024

Includes the following changes:

  • Makes the title required. It was being treated as required in the code, and really didn't work if it wasn't defined so in reality no-one is using the resource without setting the title now.
  • More correctly maps the TF plan to the API body. Fields which are unknown in the plan shouldn't be specified in the body, however they were being incorrectly set to the Go default (e.g "" for strings). This causes the resource to fail when the id isn't set in 8.14

tobio added 2 commits June 12, 2024 22:08
Previously Kibana was treating an empty ID as un-set. This change leaves the ID undefined in the json body if it's unknown in the TF plan
@tobio tobio requested a review from dimuon June 12, 2024 12:11
@tobio tobio self-assigned this Jun 12, 2024
dimuon
dimuon previously approved these changes Jun 12, 2024
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tobio tobio merged commit 332281f into main Jun 12, 2024
39 checks passed
@tobio tobio deleted the dv-8.14 branch June 12, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants