synthetics icmp and browser monitors support

[biscout42]

implelents #610

[biscout42]

Error was from TestAccSpacesDataSource, trying to re-run.

    data_source_test.go:11: Step 1/1 error: Error running post-apply plan: exit status 1
        
        Error: unable to list spaces
        
          with data.elasticstack_kibana_spaces.all_spaces,
          on terraform_plugin_test.tf line 7, in data "elasticstack_kibana_spaces" "all_spaces":
           7: data "elasticstack_kibana_spaces" "all_spaces" {
        
        400 Bad Request
--- FAIL: TestAccSpacesDataSource

[tobio]

From the docs:

If the attribute is computed and the value could be altered by other changes then a default should be avoided and a plan modifier should be used instead.

The same goes for the other Default values in the schema.

I'm not sure if these need to be computed, but if they do we likely want something like:

PlanModifiers: []{stringplanmodifiers.UseStateForUnknown(), defaultModifier("on")}

[biscout42]

Thanks a lot, let me check. The issue I had - plan was different after creation, because API returns default value for this attribute, but I didn't set it.

[biscout42]

I"m sorry, it doesn't work. TF complains

Schema Using
        Attribute Default For Non-Computed Attribute: Attribute "browser.screenshots"
        must be computed when using default.

[biscout42]

Ok, I'll leave only computed then, as a sign that API defines values, if not set.

[biscout42]

FYI: according to hashicorp/terraform-plugin-framework#285 there is no default for plan modifier and UseStateForUnknown should be enough. At least, I wasn't able to find default modifier in plugin framework. Please, let me know if I need to add it and how.

[biscout42]

@tobio , should be done, could you re-check?

[biscout42]

FYI: auto-merge is on.