Add URL support to data_view field_formats #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds support for `urlTemplate` and `labelTemplate` to data_views.field_formats - Amends API request build process to account for when some/any data_views.field_formats.attributes aren't passed in
|
💚 CLA has been signed |
kjwardy
changed the title
tobio
reviewed
Oct 1, 2024
internal/kibana/data_view/schema.go
Outdated
| @@ -334,8 +340,15 @@ func dataViewFromResponse(resp data_views.DataViewResponseObjectDataView) apiDat | |||
|
|
|||
| if params, ok := formatMap["params"]; ok { | |||
| if paramsMap, ok := params.(map[string]interface{}); ok { | |||
| fieldFormatParams := apiFieldFormatParams{} | |||
There was a problem hiding this comment.
You're never setting apiFormat.Params = &fieldFormatParams here and so the params are always nil (this is causing the current test failures).
internal/kibana/data_view/schema.go
Outdated
Comment on lines
682
to
684
| Pattern string `tfsdk:"pattern" json:"pattern,omitempty"` | ||
| Urltemplate string `tfsdk:"urltemplate" json:"urlTemplate,omitempty"` | ||
| Labeltemplate string `tfsdk:"labeltemplate" json:"labelTemplate,omitempty"` |
There was a problem hiding this comment.
These should potentially be *string since they're optional in the schema.
There was a problem hiding this comment.
That's exactly what I was missing! Thanks for the assist. Changes made and pushed.
Co-authored-by: Toby Brain <[email protected]>
Co-authored-by: Toby Brain <[email protected]>
tobio
approved these changes
Oct 1, 2024
tobio
added a commit
that referenced
this pull request
Oct 3, 2024
* origin/main: fix package policy secrets (#821) chore(deps): update codecov/codecov-action digest to b9fd7d1 (#815) Bump release memory Switch to golang 1.23.2 in release Bump release memory Prepare release v0.11.8 (#810) Add key_id as an explicit attribute (#789) standalone-output resource (#811) Add URL support to data_view field_formats (#812) migrate fleet integration_policy to framework, fix secret churn (#797) Allow mappings to be unknown to support mappings defined in index templates (#803)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
urlTemplateandlabelTemplateattributes when specifying a field in a Data View as type URL, as well as adding functionality to account for when any availablefield_formats.params.attributesdon't exist.By specifying that all fields in
apiFieldFormatParamsare optional, other custom field format types (colour, key/value, etc.) can be added much easier.