build: rewrite push-patch to use the github API instead of local git commits to ensure commits are signed #47401
+138
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commits to ensure commits are signed
MarshallOfSound
added
target/34-x-y
jkleinsc
requested changes
Jun 6, 2025
There was a problem hiding this comment.
Hmmm looks like something is amiss:
from: https://github.com/electron/electron/actions/runs/15499439929/job/43643790257?pr=47402
2025-06-06T20:53:52.7204163Z patches/node/fix_expose_the_built-in_electron_module_via_the_esm_loader.patch: needs update
2025-06-06T20:53:53.0122621Z Error: Failed to get current branch
2025-06-06T20:53:53.0123207Z at getCurrentBranch (/__w/electron/electron/src/electron/script/patch-up.js:51:11)
2025-06-06T20:53:53.0123784Z at main (/__w/electron/electron/src/electron/script/patch-up.js:72:25)
2025-06-06T20:53:53.0124353Z at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make tree, commit tree, push tree. 👍
Should make patch-up start working again on PRs
Notes: none