Use html audio element to call setSinkId for reactions and call sounds. #3321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
added
the
PR-Improvement
toger5
force-pushed
the
toger5/html-audio-for-reactions
branch
from
ab9298c to
48a1240
Compare
toger5
changed the title
toger5
force-pushed
the
toger5/html-audio-for-reactions
branch
from
576abb2 to
aecb550
Compare
toger5
force-pushed
the
toger5/html-audio-for-reactions
branch
from
aecb550 to
bf4f13b
Compare
|
With more testing on the subject of audio devices I suspect there is hope that this is not needed. lets keep this in draft until I know for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setSinkId on the audio context is not supported on safari ios. So we try using an html audio element and
audioElement.setSinkIdinstead with this PR.